Add experimental recursive iCanClean - #58
Draft
snesmaeili wants to merge 2 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #58 +/- ##
==========================================
+ Coverage 96.08% 96.37% +0.29%
==========================================
Files 65 66 +1
Lines 8170 8977 +807
Branches 1420 1607 +187
==========================================
+ Hits 7850 8652 +802
- Misses 152 155 +3
- Partials 168 170 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This draft adds an explicitly experimental RecursiveICanClean estimator. It is a new online composition built from recursive joint moments, regularized rank-aware CCA, and the published iCanClean component-selection and least-squares subtraction rule.
The implementation provides:
The documentation makes the evidence boundary explicit: the published fixed/moving-window iCanClean results do not validate this recursive implementation. The 2023 paper identifies recursive CCA as future work; this PR does not claim author-code parity or real-data effectiveness. transform is frozen, and held-out effectiveness evaluation must use calibration data disjoint from evaluation data.
Related Issue
Builds on the batch iCanClean API introduced for #25. This recursive extension comes from the evidence-aware roadmap and intentionally remains a draft pending maintainer discussion and empirical validation.
Type of Change
Verification
A repository-wide Sphinx -W run still encounters one pre-existing SmoothingBias cross-reference error. A full gallery build additionally encountered two external ZapLine data-download HTTP 503 responses. Neither originates in this change.
Remaining evidence before promotion
This PR establishes implementation, invariant, and synthetic support only. Independent recursive-CCA parity, real phantom/human effectiveness, neural-preservation, sustained-contamination, and latency/memory campaigns remain outstanding.
Checklist
Draft only: do not merge or mark ready.