fix(build): npm run dist builds the NSIS installer, not portable#6
Merged
Conversation
The `dist` script still forced `electron-builder --win portable`, which overrode the `nsis` win target added in v1.0.2 — so `npm run dist` silently built a portable .exe instead of the installer (the v1.0.2/v1.0.3 installers had to be built by invoking electron-builder directly). Point the script at `--win nsis` so it matches build config and intent. Also update the README desktop-app section (download + build instructions, roadmap, FAQ) to describe the Windows installer (`-setup.exe`) instead of the retired portable `.exe`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latent bug found while cutting v1.0.3: the
distscript still forcedelectron-builder --win portable, overriding thensiswin target added in v1.0.2. Sonpm run distsilently built a portable.exeinstead of the installer — the v1.0.2/v1.0.3 installer assets had to be built by invoking electron-builder directly.package.json:dist→electron-builder --win nsis.README.md: desktop-app download/build/roadmap/FAQ now describe the Windows installer (-setup.exe) instead of the retired portable.exe.[Unreleased].No engine/runtime change; docs + build script only.