fix: readable errors + first-run reliability (v1.0.1) and installer instead of portable (v1.0.2)#1
Open
mmoollee101-lab wants to merge 3 commits into
Open
fix: readable errors + first-run reliability (v1.0.1) and installer instead of portable (v1.0.2)#1mmoollee101-lab wants to merge 3 commits into
mmoollee101-lab wants to merge 3 commits into
Conversation
…mium launch (v1.0.1) The portable desktop app showed "Error invoking remote method 'h2p:convert': [object Object]" on any failure: the IPC layer rejected with a plain object, which Electron can't serialize, so the real cause was lost. Errors are now carried as a tagged result and re-thrown in the renderer with the original message/code/candidates intact. Also harden first-run reliability: headless Chromium launches with a longer startup timeout (antivirus often scans the freshly-unpacked ~240MB Chromium on first run, exceeding Puppeteer's default 30s and surfacing as a failed convert), and a genuine launch failure now throws a clear, actionable message. Adds an env-gated headless self-test (H2P_SELFTEST=<file.html>) for diagnostics. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The one-file portable re-unpacked ~650 MB (Electron + bundled Chromium) to a temp folder on EVERY launch, so the window took a long time to appear and looked suspicious. Switch the Windows target to an NSIS installer (per-user, no admin, assisted UI, Start-menu/Desktop shortcuts, uninstaller): it unpacks once at install time and every launch is near-instant. No conversion-engine changes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mmoollee101-lab
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Released as v1.0.1. Merges the fix into
main(protected, so via PR).Why
The v1.0.0 portable showed
Conversion failed — Error invoking remote method 'h2p:convert': [object Object]and hid the real cause: the IPC layer rejected with a plain object Electron can't serialize.Changes
H2P_SELFTEST=<file.html>) for diagnostics.Verification
Built the 1.0.1 portable and ran it end-to-end (self-extract → packaged runtime) on a real 20-slide Korean deck: detect + convert succeed, 16 MB editable .pptx, fonts embedded.
🤖 Generated with Claude Code