Skip to content

Resolved issue ber.go line 386 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hsoj wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Resolved issue ber.go line 386 #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5a9de97
Resolved issue in ber.go at line 386 where reflect.NewValue was used…
Jul 18, 2011
d0cea65
Updated package to build away from mmitton's branch.
Jul 18, 2011
76f7131
Fixed to work with Go 1. Replaced os.Error with builtin error type.
iand Jul 3, 2012
c321401
Merge pull request #1 from iand/master
Aug 7, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

include $(GOROOT)/src/Make.inc

TARG=github.com/mmitton/asn1-ber
TARG=github.com/hsoj/asn1-ber
GOFILES=\
ber.go\

Expand Down
7 changes: 3 additions & 4 deletions ber.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import (
"bytes"
"fmt"
"io"
"os"
"reflect"
)

Expand Down Expand Up @@ -167,7 +166,7 @@ func resizeBuffer( in []byte, new_size uint64 ) (out []byte) {
return
}

func readBytes( reader io.Reader, buf []byte ) os.Error {
func readBytes( reader io.Reader, buf []byte ) error {
idx := 0
buflen := len( buf )
for idx < buflen {
Expand All @@ -180,7 +179,7 @@ func readBytes( reader io.Reader, buf []byte ) os.Error {
return nil
}

func ReadPacket( reader io.Reader ) ( *Packet, os.Error) {
func ReadPacket( reader io.Reader ) ( *Packet, error) {
buf := make([]byte, 2)
err := readBytes( reader, buf )
if err != nil {
Expand Down Expand Up @@ -383,7 +382,7 @@ func Encode( ClassType, TagType, Tag uint8, Value interface{}, Description strin
p.Description = Description

if Value != nil {
v := reflect.NewValue(Value)
v := reflect.ValueOf(Value)

if ( ClassType == ClassUniversal ) {
switch Tag {
Expand Down