Fix missing CSS attr defaults

src/pyscrappy/generic/selector.py

@@ -246,7 +246,7 @@ def _values(self) -> list[str]:
         if self._pseudo == "text":
             return [s.text() for s in self]
         if self._pseudo == "attr":
-            return [str(s.attrs.get(self._attr, "")) for s in self]
+            return [str(s.attrs[self._attr]) for s in self if self._attr in s.attrs]
         return [s.html() for s in self]
 
     def get(self, default: str | None = None) -> str | None:

tests/test_generic/test_selector.py

@@ -40,6 +40,13 @@ def test_css_text_pseudo_get_and_getall(self):
     def test_css_attr_pseudo(self):
         assert _page().css("a::attr(href)").getall() == ["/a", "/b"]
 
+    def test_css_attr_missing_attribute_uses_default(self):
+        assert Selector("<a>x</a>").css("a::attr(href)").get("MISSING") == "MISSING"
+
+    def test_css_attr_getall_skips_missing_attributes(self):
+        html = "<a href='/present'>yes</a><a>missing</a>"
+        assert Selector(html).css("a::attr(href)").getall() == ["/present"]
+
     def test_css_chaining(self):
         first = _page().css(".product")[0]
         assert first.css(".price::text").get() == "$10"