feat(fleet): P-FLEET.L20 - close a spoke from its orbit node or its banner (ADR-0402) - #391
Merged
Merged
Conversation
…anner (ADR-0402) The orbit node keeps click-to-open and gains an X that takes the grid's two-step: a live spoke stops (card stays, Respawn revives it), a stopped spoke dismisses and falls back into the hub. The takeover banner gains an X beside Switch that runs the same step and returns the composer to Main. One pure spokeClose(status) decides act, label and tip; dismiss detaches the composer before the remove; refusals show on the node or in a toast. Verified live on a source engine with two real lanes; orbit tests 13 pass, renderer suite 1304 pass, desktop tsc clean, make demo-P-FLEET.L20.
emertins
force-pushed
the
feat/fleet-l20-spoke-close
branch
from
September 26, 2026 17:48
55e979d to
bb9e5b1
Compare
emertins
added a commit
that referenced
this pull request
Sep 26, 2026
mlcyclops
approved these changes
Sep 26, 2026
mlcyclops
left a comment
mlcyclops
left a comment
Owner
There was a problem hiding this comment.
Verified on an integration branch with #389/#392/#393 (tsc clean in root/desktop/server, full bun suite 5881 pass / 0 fail, make demo-P-FLEET.L20 passes). Driven live on an isolated engine: the takeover banner X stopped the driven spoke and returned the composer to Main while Main's own turn kept running; the orbit node X on the stopped spoke read Dismiss and removed the lane from the engine and the node from the DOM. Served /app.js and /styles.css carry orbit-node-x and spoke-close-btn.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owner request: on the spoke view, clicking opens the spoke in the composer (unchanged), and there is now a close option right there.
spokeClose(status)(orbit_layout.ts) decides act, label and tip; dismiss detaches the composer before the remove (fleet_grid's dismissLane order).FleetOrbitDepsgainsfleetStop/fleetRemove.Verified live on a source engine (:5392, headless Chrome, two real lanes): hover reveals the X; click stopped the lane, kept the orbit open, relabelled to Dismiss; second click removed the lane from the engine and the node from the DOM; banner X stopped the driven lane and released the composer.
orbit_layout.test.ts13 pass, renderer suite 1304 pass, desktop tsc clean,make demo-P-FLEET.L20, served /app.js and /styles.css carry the new markers.ADR-0402, PROGRESS entry included.