fix(packaging): v1.10.2 engine brick - stop stripping runtime-imported .md + robustness layers (ADR-0177), release v1.10.3 - #246
Merged
Conversation
…d .md + three robustness layers (ADR-0177), release v1.10.3 Root cause (reproduced on the shipped artifact): extraResources stripped ALL node_modules/**/*.md; #242 made dev.ts import @oh-my-pi/pi-coding-agent in-process, which imports its prompt .md files at module load - the packaged engine died at import and never bound port 5319. - packaging: drop the !node_modules/**/*.md exclusion (READMEs are cheaper than bricks) - skills_data: the omp import is type-only + LAZY inside fail-soft discoverRaw - an unloadable optional dep degrades the Skills directory, never kills the engine (verified with the bad filter deliberately restored) - main.ts: engine stdout/stderr teed to <userData>/engine.log; the failure dialog points at the log instead of asking for a terminal relaunch - packaged_boot.test.ts: CI guard that emulates the LIVE packaging exclusions with a Bun resolver plugin and boots the real dev.ts - red in <1s on the v1.10.2 state, green on the fix, so this brick class can never ship again - version bump to 1.10.3 (version.ts + package.json + about.test.ts in lockstep) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The brick
Upgrading to v1.10.2 shows "LucidAgentIDE could not start its local engine". Reproduced on the shipped artifact; the engine log is unambiguous:
The extraResources filter strips ALL
node_modules/**/*.md; #242 made dev.ts import@oh-my-pi/pi-coding-agentin-process for the first time, and that package imports its prompt.mdfiles at module load (with { type: "text" }). Packaged engine dies at import → port 5319 never binds. Same class as the v1.9.0typescript-exclusion brick.The fix - once, then never again
!node_modules/**/*.md(a few MB of READMEs vs a bricked engine).skills_data.tsis type-only + lazy inside the already-fail-softdiscoverRaw- verified the engine still boots with the bad filter deliberately restored (feature degrades to bundled-only skills).<userData>/engine.log; the failure dialog now points at that file.desktop/packaged_boot.test.ts): emulates the LIVE packaging exclusions with a Bun resolver plugin and boots the real dev.ts, requiring/api/health. Proven red (<1s) on the v1.10.2 state, green on this fix.Release
Version bumped to v1.10.3 in lockstep. After merge I'll tag
v1.10.3→ installers build → verify the shipped Windows artifact boots on the machine that reproduced the brick before calling it done.🤖 Generated with Claude Code