Additive update to retain the "is_valid" property that the safety 1.2… - #1627
Open
bollacker wants to merge 1 commit into
Open
Additive update to retain the "is_valid" property that the safety 1.2…#1627bollacker wants to merge 1 commit into
bollacker wants to merge 1 commit into
Conversation
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
rogthefrog
reviewed
Sep 1, 2026
| def is_valid(self) -> bool: | ||
| """Whether the verdict is usable for scoring. | ||
|
|
||
| Always true for a plain Safety. Subclasses whose verdict has a failure |
Contributor
There was a problem hiding this comment.
If the child classes all have this method/property, presumably declaring it here is to force any future child class to have it too, right? If that's so, I'd mark it abstract and/or raise NotImplementedError, instead of always returning True, because that could lead to sneaky bugs.
Contributor
|
I think this was already solved. The change is merged into Roger's working branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… DAG generates