Include run_id in benchmark record and annotation file names - #1588
Open
golipraneetha wants to merge 1 commit into
Open
Include run_id in benchmark record and annotation file names#1588golipraneetha wants to merge 1 commit into
golipraneetha wants to merge 1 commit into
Conversation
Previously these files were named only after the benchmark UID, so each new run silently overwrote the previous run's output. Reusing the existing per-run run_id (already used for the journal file name) makes each run's files unique without introducing a new identifier. Fixes mlcommons#1415
golipraneetha
temporarily deployed
to
Scheduled Testing
July 24, 2026 23:33 — with
GitHub Actions
Inactive
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously these files were named only after the benchmark UID, so each new run silently overwrote the previous run's output. Reusing the existing per-run run_id (already used for the journal file name) makes each run's files unique without introducing a new identifier.
Fixes #1415