Allows Python Function Registration - #18
Merged
Merged
Conversation
kavigupta
previously requested changes
Oct 20, 2025
| /// - `lazy_args`: optional indices of lazy arguments; use None for strict | ||
| /// - `pyfunc`: owned Python callable captured into this production | ||
| #[cfg(feature = "python")] | ||
| pub fn add_python_primitive( |
Collaborator
There was a problem hiding this comment.
This function should not exist directly, instead, have a function create_python_production or something in py.rs, and then call .add_entry(create_python_production(...)) where you would call this.
|
|
||
| /// by dreamegg::domain::Val so they don't appear here. | ||
| #[derive(Clone,Debug, PartialEq, Eq, Hash)] | ||
| pub enum PyVal { |
Collaborator
There was a problem hiding this comment.
This could potentially just be PyAny
kavigupta
reviewed
Feb 19, 2026
| @@ -1,6 +1,5 @@ | |||
| #[macro_use] | |||
| mod macros; | |||
|
|
|||
Collaborator
There was a problem hiding this comment.
check this out to main, to avoid a messy diff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.