fix: include finite-sample offset in MinTRL - #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
0.1.0b24.Root cause
The production formula rounded the continuous asymptotic quantity without first adding the finite-sample leading observation. The visualization separately implemented the asymptotic form, so both paths understated the required track record by one observation in the Chapter 16 example.
Impact
For finite MinTRL results, the continuous quantity receives the canonical
+1before integer ceiling. The seeded Chapter 16 Strategy_14 result changes from 212 to 213 days. Infinite results and the observed-Sharpe-at-or-below-target behavior are unchanged.Verification
0.1.0b24, Strategy_14, MinTRL213.0