Repository navigation
fix: honor CME crypto cutover and business trade dates - #111
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #107
Outcome
Honor CME Globex cryptocurrency futures/options' May29,2026 transition while preserving the historical backend schedule through that date. Friday launch maintenance ends16:30 Chicago time; ordinary weekdays reopen16:02 and Saturday maintenance is02:00-04:00. Following-business-day trade labels span weekends and holidays. Ordinary spot24/7 keeps civil dates and does not inherit CME maintenance. Other CME products and the upstream registry are unchanged.
Reuse shared FeedSpec selection and native tradable intervals. The local adapter combines the existing historical crypto schedule with CME_TradeDate business labels. Its holiday rules were inspected against CME's2026 reporting table; actual provider cases cover Juneteenth, observed Independence Day, Labor Day, Thanksgiving, Christmas and ordinary Columbus/Veterans Day controls. Session assignment/completion and intraday gap classification query through the next business date instead of relying on one/two-day padding. Preserve existing padding for other calendars.
Executed evidence
Review and compatibility
Owner reviewed actual transition dates, Chicago DST conversion, business holidays versus trading closures, interval boundary sides, inserted versus retained observations, shared declaration precedence and downstream query coverage. AI-assisted implementation/tests/prose under maintainer direction; no independent reviewer claimed.
Canonical calendar selection is explicit argument > declared feed metadata > NYSE. ExplicitNone stays disabled. The CME compatibility exchange selector still maps to CME Globex Crypto, not every CME product or spot-quoted futures. See the updated existing sessions guide for authoritative CME links and scope.
Data0.2.1 remains immutable. General intraday acquisition planning(issue110), general schedule-aware filling(issue109), validation(issue108) and published-Specs consumer qualification are separate accepted work, not completion claims here. No release/deployment.