Repository navigation
fix: avoid false crypto weekend warnings on complete intraday windows - #106
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #105
Outcome
CryptoSessionValidator no longer infers a missing weekend from an input having seven rows. Existing chronological gap detection remains unchanged. A complete seven-minute or seven-hour Monday window is valid; deleting actual weekend daily bars still reports the Friday-to-Monday outage. AssetValidator's crypto continuity path receives the same correction. Volume, price, maintenance-window and actual gap rules are unchanged.
This focused repair is independent of the calendar-contract stack and does not claim that the separate canonical calendar-selection migration is complete.
Executed verification
AI-assisted implementation and regressions under maintainer direction. Owner reviewed the producing APIs, base/fix results and exact11-line production deletion. No independent reviewer claimed. No release/deployment or modification of published0.2.1.