Resolve $ref in response header objects#116
Merged
mkon merged 1 commit intoJun 24, 2026
Merged
Conversation
`Doc::Response#headers` mapped the raw header hash straight to `Doc::Header`,
so a header defined as a `$ref` (e.g. to `#/components/headers/*`) was never
dereferenced. `Doc::Header#schema` then returned `nil`, and
`Validators::Headers` raised `NoMethodError: undefined method 'empty?' for nil`
from `JSONSchemer.schema(nil)` whenever such a header was present on the
response being validated.
Build headers via `@schema.navigate('headers')`, mirroring how
`WithParameters#parameters` already resolves parameters, so inline and
referenced headers are followed identically.
Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doc::Response#headersmapped the raw header hash straight toDoc::Header, so a header defined as a$ref(e.g. to#/components/headers/*) was never dereferenced.Doc::Header#schemathen returnednil, andValidators::HeadersraisedNoMethodError: undefined method 'empty?' for nilfromJSONSchemer.schema(nil)whenever such a header was present on the response being validated.Build headers via
@schema.navigate('headers'), mirroring howWithParameters#parametersalready resolves parameters, so inline and referenced headers are followed identically.Closes #114