fix: fix RHVoice library installation after version update#404
Open
IldarMinaev wants to merge 1 commit into
Open
fix: fix RHVoice library installation after version update#404IldarMinaev wants to merge 1 commit into
IldarMinaev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix RHVoice installation after the RHVoice source update in
cmake/rhvoice.cmake.The install scripts still expected the old hardcoded
1.2.2filenames. This causedmake install/ Archmakepkgto fail during the package step:This PR:
cmake/rhvoice.cmakeTesting
makepkg -f -ecmake --install src/dsnote/build --prefix /tmp/dsnote-install-check1.2.2is no longer hardcoded in tracked source files