Render content off the request handler's thread.#141
Open
mkantor wants to merge 3 commits into
Open
Conversation
I'm working on #5 which will involve moving rendering off of the main request-handling thread. This means `Media` needs to be `Send` so that it can cross thread boundaries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The primary goal of this changeset is to make it so requests can't be blocked on slow template rendering, but rather than being targeted to templates only, it moves rendering for all content kinds to a separate blocking thread pool.
I was originally going to try and defer the first chunk of the body stream in
RegisteredTemplatewhile the template renders, but in practice that means passing an engine/registry around and generally makes things complicated (partly because of thegethelper). Effort could be better spent making handlebars rendering inherently be async/streaming, but that's something to explore another day.Fixes #5.