Fix username encoding in PublicKeyCredentialUserEntity - #79
Merged
Conversation
Owner
|
welcome back @ganiyevuz, Why username became an int? |
Contributor
Author
|
Its not username its username field like when people use phone number or some kind of non string field as their login method they must use charfield currently if they wont it is giving encode method not found error maybe this is not happening for other but when i use telegram id as their username and use integerfield i got this error. This is small and probaly not all users face this issue but having extra check is ok |
Owner
|
Hello @ganiyevuz, Got it, It is merged and released as v2.2b2, please check it and it will be released soon. Thanks for the continuous contributions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
convert USERNAME_FIELD to string to fix AttributeError at /passkeys/reg/begin/
'int' object has no attribute 'encode' error