837i - #13
Open
Wylan wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been meaning to make a pull request for this for a while. I added a 837i.xml file, based on the the 837p file with some changes and additional segments as needed.
I also had to make some changes to the required field on several segments. If they are marked as required=y and have a minimum character count, blank spaces are generated in the field when creating a message. This caused the resulting 837i to be rejected by some receivers as invalid.
This hasn't caused any issues for the other message types we use (837p, 835, 277, 999).
Hopefully someone finds this useful, please let me know if any changes are needed.