Skip to content

Case insensitive changes - #708

Open
ysuarez wants to merge 5 commits into
mjordan:mainfrom
ysuarez:case_insensitive_changes
Open

Case insensitive changes#708
ysuarez wants to merge 5 commits into
mjordan:mainfrom
ysuarez:case_insensitive_changes

Conversation

@ysuarez

@ysuarez ysuarez commented Nov 2, 2023

Copy link
Copy Markdown
Contributor

Link to Github issue or other discussion

What does this PR do?

This makes some string comparisons case insensitive to allow more flexible data to be accepted.

What changes were made?

I this PR just adds a call to .lower() in the method chaining, so code like .startswith() and .endswith() becomes .lower().startswith() and .lower().endswith()

How to test / verify this PR?

Need to pass a .xlsx file that has at least one of the file suffix letters are in upper case.

Also, need to pass a "file" field value of "http" were one of the protocol's letters are in upper case.

Interested Parties

@mjordan


metadata_case_insensitive.Xlsx

Checklist

  • Before opening this PR, have you opened an issue explaining what you want to to do?
  • Have you run pycodestyle --show-source --show-pep8 --ignore=E402,W504 --max-line-length=200 yourfile.py?
  • Have you included some configuration and/or CSV files useful for testing this PR?
  • Have you written unit or integration tests if applicable?
  • Does the code added in this PR require a version of Python that is higher than the current minimum version?
  • If the changes in this PR require an additional Python library, have you included it in setup.py?
  • If the changes in this PR add a new configuration option, have you provided a default for when the option is not present in the .yml file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant