Skip to content

Added additional mapping - #394

Open
ajstanley wants to merge 3 commits into
mjordan:mainfrom
ajstanley:issue_393
Open

Added additional mapping#394
ajstanley wants to merge 3 commits into
mjordan:mainfrom
ajstanley:issue_393

Conversation

@ajstanley

@ajstanley ajstanley commented Feb 25, 2022

Copy link
Copy Markdown
Contributor

Link to Github issue or other discussion

Issue 393

What does this PR do?

Allows mp3s with audio/mp3 to be ingested

What changes were made?

Adds additional mimetype mapping

How to test / verify this PR?

Ingest mp3 from S3

Interested Parties

@mjordan


Checklist

  • Have you run pycodestyle --show-source --show-pep8 --ignore=E402,W504 --max-line-length=200 yourfile.py?
  • Have you included same configuration and/or CSV files useful for testing this PR?
  • Have you written unit or integration tests if applicable?
  • If the changes in this PR require an addiional Python library, have you included it in setup.py?
  • If the changes in this PR add a new configuration option, have you provided a default for when the option is not present in the .yml file?

@ajstanley

Copy link
Copy Markdown
Contributor Author

I'll make this configurable when I get a chance, so anyone encountering a weird mimetype can add their own extension, but this fixes the problem with the s3 headers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant