Repository navigation
refactor(xpp): fully-qualify runtime::ScheduledIo in the net layer - #209
Merged
Merged
Conversation
Drop the `using runtime::ScheduledIo` and `runtime::_::{readable,writable}`
aliases from poll_evented.h and spell the names out explicitly at every
use site (poll_evented.h, net/tcp.{h,cpp}, net/udp.cpp). The net layer's
dependency on the runtime I/O readiness driver is now explicit rather
than hidden behind header-level using-declarations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drop the
using runtime::ScheduledIoandruntime::_::{readable,writable}aliases from
poll_evented.hand spell the names out explicitly at everyuse site (
poll_evented.h,net/tcp.{h,cpp},net/udp.cpp).After
ScheduledIomoved intoxpp::runtime(#208), the net layer keptits short references working via header-level
using-declarations inpoll_evented.h. This makes the net layer's dependency on the runtimeI/O readiness driver explicit rather than hidden behind those aliases.
Validation
xpp_test+xpp_coro_test: 100% pass.