Feat/phase 2 machine grouping - #129
Merged
Merged
Conversation
- Machine.group_name VARCHAR(64) column (nullable, indexed)
- Idempotent ALTER TABLE migration in init_db (safe on existing DBs)
- PATCH /api/machines/{id} for group assignment, with strict validation:
letters/numbers/-/_/./space only, 64 char max, 'ungrouped' reserved
- GET /api/groups returns counts + status breakdown, NULL bucketed as
synthetic 'ungrouped' (sorted last)
- POST /api/report honours machine.group_name self-tag only when no
dashboard-set group exists (dashboard PATCH wins)
- Frontend: getGroups(), updateMachineGroup(), MachineGroup type
- New reusable GroupPicker component (input + filtered dropdown +
create-new + ungroup, full keyboard nav, click-outside close)
- MachineDetail summary row: clickable Group card with optimistic
update + revert-on-error
- PATCH response now mirrors GET shape (includes latest_report) so
callers can setMachine(patchResponse) without losing diagnostics
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Topology right panel: prominent 'Open full details →' button next to status pill (was no link at all) - Topology status pill now shows headline issue count: 'PASS · 0 issues' - Removed redundant 'Summary' 2x2 grid from Topology right panel — the diagnostic cards' status badges already convey the same info - Fleet hostname is now a Link to MachineDetail (universal pattern: click the name to open it). Row chevron click still expands inline. - Fleet expanded section: 'Open full details →' promoted to a prominent button at the top with a one-line hint about what's there; removed the buried small link at the bottom of diagnostics Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.