Fix typo error and calculated value - #2
Open
diegomvh wants to merge 8 commits into
Open
Conversation
jayvdb
approved these changes
Jul 24, 2019
jayvdb
left a comment
There was a problem hiding this comment.
good changes, especially the Python 3 support
|
If you want to retain Python 2 support, that should be fairly easy to do. |
|
I see https://github.com/prymatex/ponyguruma has this. But nobody is claiming and publishing to https://pypi.org/project/ponyguruma/ ;-( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
We using ponyguruma for a project hosted here in github.
The errors commited in this request was solved in the d3f0's repository of your project.
This commit fix two errors in _highlevel.py file:
First error:
NameError Traceback (most recent call last)
/mnt/datos/workspace/GitHub/ponyguruma/build/lib.linux-i686-2.7/ in ()
----> 1 pattern.split("Hello World")
/mnt/datos/workspace/GitHub/ponyguruma/build/lib.linux-i686-2.7/ponyguruma/_highlevel.py in split(self, string, maxsplit, pos, endpos, flat)
179 startstring = string[:pos]
180 n = 0
--> 181 push_match = (flag and result.append or result.extend)
182 while 1:
183 state = regexp_match(self, string, pos, endpos, False)
NameError: global name 'flag' is not defined
Second error: