Skip to content

Replace dependency babel-eslint with @babel/eslint-parser ^7.11.0 - #1070

Open
renovate[bot] wants to merge 1 commit into
masterfrom
renovate/babel-eslint-replacement
Open

Replace dependency babel-eslint with @babel/eslint-parser ^7.11.0#1070
renovate[bot] wants to merge 1 commit into
masterfrom
renovate/babel-eslint-replacement

Conversation

@renovate

@renovate renovate Bot commented Jul 8, 2023

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Type Update Change
babel-eslint@babel/eslint-parser dependencies replacement ^10.0.0^7.11.0

⚠️ Renovate's replacement functionality does not currently wire in the release age for a package, so the Minimum Release Age checks can apply. You will need to manually validate the Minimum Release Age for these package(s).

This is a special PR that replaces babel-eslint with the community suggested minimal stable replacement version.


Configuration

📅 Schedule: (in timezone US/Eastern)

  • Branch creation
    • "every weekend"
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate
renovate Bot force-pushed the renovate/babel-eslint-replacement branch 2 times, most recently from 24f0649 to b11cf1a Compare July 18, 2023 02:45
@renovate
renovate Bot force-pushed the renovate/babel-eslint-replacement branch from b11cf1a to a526ff8 Compare August 10, 2023 20:42
@renovate
renovate Bot force-pushed the renovate/babel-eslint-replacement branch from a526ff8 to e466f0b Compare August 28, 2023 02:42
@renovate
renovate Bot force-pushed the renovate/babel-eslint-replacement branch from e466f0b to 436dfde Compare September 20, 2023 11:49
@renovate
renovate Bot force-pushed the renovate/babel-eslint-replacement branch from 436dfde to f080d24 Compare November 17, 2023 08:31
@renovate
renovate Bot force-pushed the renovate/babel-eslint-replacement branch 2 times, most recently from 0800f99 to 354a1da Compare February 4, 2024 14:37
@renovate
renovate Bot force-pushed the renovate/babel-eslint-replacement branch from 354a1da to fb5a0a5 Compare March 21, 2024 08:45
@renovate renovate Bot changed the title fix(deps): replace dependency babel-eslint with @babel/eslint-parser Replace dependency babel-eslint with @babel/eslint-parser Mar 26, 2024
@renovate
renovate Bot force-pushed the renovate/babel-eslint-replacement branch 2 times, most recently from 4f19981 to 13938c6 Compare March 30, 2024 15:00
@renovate
renovate Bot force-pushed the renovate/babel-eslint-replacement branch from 13938c6 to 27b03c3 Compare April 3, 2024 12:17
@renovate
renovate Bot force-pushed the renovate/babel-eslint-replacement branch 2 times, most recently from 0804b03 to 616a1ff Compare April 16, 2024 13:52
@renovate renovate Bot changed the title Replace dependency babel-eslint with @babel/eslint-parser Replace dependency babel-eslint with @babel/eslint-parser ^7.11.0 Apr 17, 2024
@renovate
renovate Bot force-pushed the renovate/babel-eslint-replacement branch 2 times, most recently from 2385865 to a04f081 Compare April 22, 2024 15:54
@renovate
renovate Bot force-pushed the renovate/babel-eslint-replacement branch 3 times, most recently from d9c7bb5 to 08b0625 Compare April 29, 2024 20:37
@renovate
renovate Bot force-pushed the renovate/babel-eslint-replacement branch 9 times, most recently from abf084b to 52935ec Compare May 16, 2024 16:05
@renovate
renovate Bot force-pushed the renovate/babel-eslint-replacement branch 11 times, most recently from a30ebbf to 3e5fbb9 Compare June 8, 2024 16:10
@renovate
renovate Bot force-pushed the renovate/babel-eslint-replacement branch 2 times, most recently from 7cdf9ae to c9c8563 Compare June 13, 2024 17:57
@renovate
renovate Bot force-pushed the renovate/babel-eslint-replacement branch from c9c8563 to d17d4ad Compare July 21, 2024 14:24
@renovate
renovate Bot force-pushed the renovate/babel-eslint-replacement branch 2 times, most recently from a8a5dc9 to 3ec1700 Compare August 6, 2024 12:11
@renovate
renovate Bot force-pushed the renovate/babel-eslint-replacement branch 2 times, most recently from 2261e34 to bd8fd43 Compare September 26, 2024 23:06
@renovate
renovate Bot force-pushed the renovate/babel-eslint-replacement branch from bd8fd43 to a4f133c Compare October 9, 2024 09:12
@renovate
renovate Bot force-pushed the renovate/babel-eslint-replacement branch from a4f133c to bdeebd5 Compare December 2, 2024 12:06
@renovate
renovate Bot force-pushed the renovate/babel-eslint-replacement branch from bdeebd5 to c2c44df Compare January 23, 2025 18:52
@renovate
renovate Bot force-pushed the renovate/babel-eslint-replacement branch from c2c44df to 0a35b6b Compare February 9, 2025 15:14
@renovate
renovate Bot force-pushed the renovate/babel-eslint-replacement branch 2 times, most recently from 68f7228 to 2e263ea Compare March 10, 2025 10:40
@renovate
renovate Bot force-pushed the renovate/babel-eslint-replacement branch from 2e263ea to 8489841 Compare March 13, 2025 12:57
@marslanabdulrauf

Copy link
Copy Markdown
Contributor

It requires upgrading eslint-config-mitodl as well which also requires node version to be "^18.18.0 || >=20.0.0"

@marslanabdulrauf

Copy link
Copy Markdown
Contributor

I have tried upgrading eslint-config-mitodl however due to lack of Changelog information couldn't figure out early that version >=1.0.0 are only configured for typescript and OVS does not use typescript.

Either we need to remove this altogether and write custom configuration in .eslintrc file or we can upgrade our project to typescript.

Comment thread package.json
"@silvermine/videojs-quality-selector": "^1.3.1",
"autoprefixer": "^10.0.0",
"babel-eslint": "^10.0.0",
"@babel/eslint-parser": "^7.11.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Replacing babel-eslint with @babel/eslint-parser may break the linting process, as the new parser requires a Babel configuration file which is not present.
Severity: MEDIUM

Suggested Fix

Create a babel.config.js file in the project root to satisfy @babel/eslint-parser's requirement. Alternatively, configure the parser directly within the .eslintrc file by adding a parserOptions section that sets requireConfigFile: false.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: package.json#L36

Potential issue: The project replaces `babel-eslint` with `@babel/eslint-parser`. The
new parser, by default, requires a dedicated Babel configuration file (e.g., `.babelrc`
or `babel.config.js`) to be present in the project root. Since no such file exists, and
the `.eslintrc` does not explicitly configure the parser, the `yarn lint` command is
likely to fail. This assumes the extended configuration, `eslint-config-mitodl`, does
not already handle this new parser's requirements.

Did we get this right? 👍 / 👎 to inform future reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant