Replace dependency babel-eslint with @babel/eslint-parser ^7.11.0 - #1070
Replace dependency babel-eslint with @babel/eslint-parser ^7.11.0#1070renovate[bot] wants to merge 1 commit into
Conversation
24f0649 to
b11cf1a
Compare
b11cf1a to
a526ff8
Compare
a526ff8 to
e466f0b
Compare
e466f0b to
436dfde
Compare
436dfde to
f080d24
Compare
0800f99 to
354a1da
Compare
354a1da to
fb5a0a5
Compare
4f19981 to
13938c6
Compare
13938c6 to
27b03c3
Compare
0804b03 to
616a1ff
Compare
2385865 to
a04f081
Compare
d9c7bb5 to
08b0625
Compare
abf084b to
52935ec
Compare
a30ebbf to
3e5fbb9
Compare
7cdf9ae to
c9c8563
Compare
c9c8563 to
d17d4ad
Compare
a8a5dc9 to
3ec1700
Compare
2261e34 to
bd8fd43
Compare
bd8fd43 to
a4f133c
Compare
a4f133c to
bdeebd5
Compare
bdeebd5 to
c2c44df
Compare
c2c44df to
0a35b6b
Compare
68f7228 to
2e263ea
Compare
2e263ea to
8489841
Compare
|
It requires upgrading |
|
I have tried upgrading Either we need to remove this altogether and write custom configuration in |
| "@silvermine/videojs-quality-selector": "^1.3.1", | ||
| "autoprefixer": "^10.0.0", | ||
| "babel-eslint": "^10.0.0", | ||
| "@babel/eslint-parser": "^7.11.0", |
There was a problem hiding this comment.
Bug: Replacing babel-eslint with @babel/eslint-parser may break the linting process, as the new parser requires a Babel configuration file which is not present.
Severity: MEDIUM
Suggested Fix
Create a babel.config.js file in the project root to satisfy @babel/eslint-parser's requirement. Alternatively, configure the parser directly within the .eslintrc file by adding a parserOptions section that sets requireConfigFile: false.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: package.json#L36
Potential issue: The project replaces `babel-eslint` with `@babel/eslint-parser`. The
new parser, by default, requires a dedicated Babel configuration file (e.g., `.babelrc`
or `babel.config.js`) to be present in the project root. Since no such file exists, and
the `.eslintrc` does not explicitly configure the parser, the `yarn lint` command is
likely to fail. This assumes the extended configuration, `eslint-config-mitodl`, does
not already handle this new parser's requirements.
Did we get this right? 👍 / 👎 to inform future reviews.
This PR contains the following updates:
^10.0.0→^7.11.0This is a special PR that replaces
babel-eslintwith the community suggested minimal stable replacement version.Configuration
📅 Schedule: (in timezone US/Eastern)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.