Enforce one product per purchasable object - #3847
Open
cp-at-mit wants to merge 1 commit into
Open
Conversation
Updates `Product` uniqueness to always enforce a single product per `(object_id, content_type)` pair, instead of allowing duplicates when one is inactive. Adds a migration to replace the old conditional constraint and updates the model test to cover both active and inactive duplicate creation attempts.
OpenAPI ChangesShow/hide changesUnexpected changes? Ensure your branch is up-to-date with |
cp-at-mit
marked this pull request as ready for review
August 12, 2026 16:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
https://github.com/mitodl/hq/issues/11729
Description (What does it do?)
Updates
Productuniqueness to always enforce a single product per(object_id, content_type)pair, instead of allowing duplicates when one is inactive. Adds a migration to replace the old conditional constraint and updates the model test to cover both active and inactive duplicate creation attempts.How can this be tested?
Create a product, then attempt to create a second active product for the same object. This should not work even if the first product is deactivated.