Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions vector_search/tasks.py
Original file line number Diff line number Diff line change
Expand Up @@ -433,9 +433,10 @@ def embed_new_learning_resources(self):
)
]
)
embed_tasks = celery.group(tasks)

return self.replace(embed_tasks)
# Dispatch chunks sequentially instead of materializing the whole lookback
# window as one group. This bounds broker queue depth and prevents KEDA from
# scaling the embeddings worker fleet for a short-lived fan-out burst.
return _replace_with_chain(self, tasks)


@app.task(bind=True)
Expand Down
17 changes: 16 additions & 1 deletion vector_search/tasks_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -235,13 +235,28 @@ def test_embed_new_learning_resources(mocker, mocked_celery):

with pytest.raises(mocked_celery.replace_exception_class):
embed_new_learning_resources.delay()
list(mocked_celery.group.call_args[0][0])

assert generate_embeddings_mock.si.call_count == 1
embedding_signature = generate_embeddings_mock.si.return_value
mocked_celery.chain.assert_called_once_with(embedding_signature)
mocked_celery.group.assert_not_called()
assert mocked_celery.replace.call_args[0][1] == mocked_celery.chain.return_value
embedded_ids = generate_embeddings_mock.si.mock_calls[0].args[0]
assert sorted(new_resource_ids) == sorted(embedded_ids)


def test_embed_new_learning_resources_no_work(mocker, mocked_celery):
"""embed_new_learning_resources should not dispatch an empty canvas"""
settings.QDRANT_EMBEDDINGS_TASK_LOOKBACK_WINDOW = 1
mocker.patch("vector_search.tasks.now_in_utc", return_value=now_in_utc())

assert embed_new_learning_resources.run() is None

mocked_celery.chain.assert_not_called()
mocked_celery.group.assert_not_called()
mocked_celery.replace.assert_not_called()


def test_embed_new_content_files(mocker, mocked_celery):
"""
embed_new_content_files should generate embeddings for new content files
Expand Down
Loading