fix(mfe-slots): migrate mitxonline right-sidebar (AskTIM + feedback) slot to canonical right_sidebar.v1 id - #153
Merged
Conversation
…ebar.v1 id The Learning MFE right-sidebar slot was renamed upstream to `org.openedx.frontend.learning.right_sidebar.v1`; the id we register our AskTIM/feedback coordinator under, `org.openedx.frontend.learning.notifications_discussions_sidebar.v1`, is retained only as a deprecated alias marked for removal after one deprecation cycle (ADR 0010). mitxonline builds frontend-app-learning from `master` in CI/QA/Prod, so when the alias is removed upstream it reaches Prod on the next MFE rebuild — the config key would match no slot, the framework would fall back to the default <Sidebar />, and the AskTIM + inline feedback column would silently disappear with no build error. During the deprecation window both ids resolve to the same RightSidebarSlot, so switching to the canonical id is a behavioral no-op today and future-proofs us against the alias removal. The block is mitxonline-gated; other deployments are unaffected. Refs mitodl/hq#11820
zamanafzal
changed the title
zamanafzal
marked this pull request as ready for review
August 11, 2026 08:25
There was a problem hiding this comment.
Pull request overview
Migrates the MITx Online Learning MFE sidebar integration to the canonical slot ID.
Changes:
- Replaces the deprecated sidebar slot alias with
right_sidebar.v1.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
… RightSidebarSlot Follow-up to the slot-ID migration: the legacy slot catalog row still documented the integration under the deprecated `notifications_discussions_sidebar.v1` key and linked to the old `NotificationsDiscussionsSidebarSlot` path, which would direct future maintenance back to the alias. Point it at the canonical `right_sidebar.v1` / `RightSidebarSlot`. Also repoint the link from the mitodl fork (whose master still only has the old slot, and which mitxonline does not build from) to the openedx upstream repo, where the renamed slot exists and which is the actual build source — matching every other row in this catalog. Refs mitodl/hq#11820
asadali145
reviewed
Aug 12, 2026
asadali145
left a comment
asadali145
left a comment
Contributor
There was a problem hiding this comment.
LGTM! I am not testing changes as it looks quite straight forward.
asadali145
approved these changes
Aug 12, 2026
asadali145
left a comment
asadali145
left a comment
Contributor
There was a problem hiding this comment.
LGTM! I am not testing changes as it looks quite straight forward.
asadali145
added
waiting on author
and removed
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
https://github.com/mitodl/hq/issues/11820
Description (What does it do?)
Migrates the mitxonline Learning MFE right-sidebar override (AskTIM + inline feedback drawer, hosted by
SidebarAIDrawerCoordinator) off the deprecated slot ID onto the canonical one, indeployments/mit-ol/mfe_slot_config/legacy/learning-mfe-config.env.jsx. One-line key change; the block contents are byte-for-byte unchanged.How can this be tested?
Prerequisite — AskTIM (+ feedback) must already render locally in the right sidebar. If it isn't set up, follow the "How can this be tested?" section of mitodl/ol-infrastructure#4232 to get the AI drawer working locally: mount
frontend-app-learning, enableol_openedx_chat, build/stage the smoot-design bundle intopublic/static/smoot-design/, copy the slot files to the repo root, wireenv.config.jsx, and setENABLE_AI_DRAWER_SLOT=truein.env.development.Then verify this migration using the new slot ID:
env.config.jsx, apply this PR's one-line change:npm run dev(the config is read at startup) and open a course unit.right_sidebar.v1.Behavioral no-op today: upstream
master'sRightSidebarSlotstill lists the old ID as a deprecated alias, so both IDs resolve to the same slot.Additional Context
frontend-app-learningfrommaster, so once the alias is dropped the old key matches no slot and the sidebar (AskTIM + feedback) silently disappears with no build error. Switching now future-proofs us.