Skip to content

Fix command path separator for windows #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchpaulus merged 1 commit into from
Jul 10, 2026
Merged

Fix command path separator for windows #278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed

- On Windows, a command name containing a forward slash (e.g. `./script.msh`)
is now treated as a file reference instead of being searched for on `PATH`,
matching the behavior on Linux/macOS. Previously only backslashes were
recognized as path separators in command position on Windows, so
cross-platform scripts invoking local scripts with `./` failed.
- Interactive programs now work as a stage of a pipeline. A command that drives
the terminal (e.g. `... | nvim -`, `... | less`, `... | fzf`) is no longer
stopped on startup: every external stage of a pipeline is now placed in one
Expand Down
6 changes: 4 additions & 2 deletions mshell/Evaluator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3870,8 +3870,10 @@ func RunProcess(list MShellList, context ExecuteContext, state *EvalState) (Eval
var allArgs []string
var cmdPath string

// Check if there is a directory separator in the name of the command trying to execute
if strings.Contains(commandLineArgs[0], string(os.PathSeparator)) {
// Check if there is a directory separator in the name of the command trying to execute.
// Use the platform IsPathSeparator so that './script' is a file reference on Windows too,
// where os.PathSeparator alone would miss the forward slash.
if strings.ContainsFunc(commandLineArgs[0], func(r rune) bool { return r < 256 && IsPathSeparator(uint8(r)) }) {
cmdPath = commandLineArgs[0]
} else {
var found bool
Expand Down