Repository navigation
Fix hardcoded path in plist, add hidutil cleanup to uninstall, update CONTRIBUTING - #11
Merged
Merged
Conversation
… CONTRIBUTING - Replace hardcoded /Users/mjp path in LaunchAgent plist with __APP_DIR__ placeholder, templated by install.sh via sed at install time. Fixes the plist for anyone other than the original author. - Add hidutil UserKeyMapping clear to uninstall.sh as belt-and-suspenders cleanup in case the daemon was already stopped or didn't clean up. - Update CONTRIBUTING.md with lint configuration section explaining the strict clippy rules (deny unwrap/panic/unsafe, pedantic warnings).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/Users/mjp/...path incom.local.switcheroo.plistwith an__APP_DIR__placeholder thatinstall.shtemplates viasedat install time. Previously the plist only worked on the original author's machine.hidutil property --set '{"UserKeyMapping":[]}'touninstall.shso modifier remaps are cleared even if the daemon was already stopped or crashed without cleanup.deny unwrap/panic/unsafe, pedantic warnings) so contributors know what to expect.