[mitch030504]

Requested by Mitch · project thread

Before: a few renderer bugs that upstream (patchzyy/Wiicompiled) fixed in its KartPad batch (patchzyy#244, commit 6f14bde) were still in the fork. Draws with an incomplete last primitive could index vertices that belonged to the next merged draw or past the buffer, merges could wrap the 16-bit index offset, native EFB readback sampled only row 0 and used a pipeline built for the wrong format on BGRA surfaces, and a failed graphics start aborted with little detail. While the GPU was two frames behind, begin_frame also spun a whole core on ProcessEvents until the next staging buffer mapped.

After: those fixes are in, adapted to the VR merge path, and the staging-buffer wait sleeps on a condition variable (woken by the map callback, at most 1 ms per wait) instead of spinning. Release builds skip Dawn validation and robustness, so the out-of-range indices and the pipeline/attachment format mismatch were not being caught at all on the Frame.

How: each fix is its own commit. Upstream's staging-capacity split from the same batch is deliberately left out, because it rewires the frame worker, FIFO drain and merge locking that the GX thread and stereo replay changed.

Commit	What it fixes
Wake every pipeline waiter	Compiler workers and renderer waiters share one condvar; notify_one could wake the wrong one, and promotion to priority woke nobody
Packed three-byte attributes	WGSL load_u24 no longer reads the next word when all three bytes fit in the first
Lock the video render mode	vi render mode reads and writes are now under a mutex; the resize request happens after the lock is released
Pipeline cache rows	Rows with inconsistent size or compression metadata become cache misses instead of driving a bad allocation or copy
Draw boundaries	Incomplete primitives emit no indices, empty draws are skipped, merges stop before 65,536 vertices, never fold into a single line/point draw, and break after GXInvalidateVtxCache or a vertex-format switch. The fork's VR merge conditions (vertex motion, ortho in stereo, native wheel) are kept
GEN_MODE	The first all-zero GEN_MODE write is decoded instead of deduplicated against the zeroed cache
TEV liveness test	Fixes the test that was already failing on openxr-work (it assumed no alignment rounding)
EFB readback	Readback uniform no longer clamps Y to row 0. Blit pipelines are built for RGBA8, BGRA8 and the surface format and picked by destination. Upstream only builds RGBA8/BGRA8; the surface format is added so an unusual surface keeps working. The Quest 1 path is unchanged
Copy source snapshot	The snapshot texture gets CopySrc, which the plain-copy resolve path needs
Startup errors	aurora_initialize returns the first adapter, device or window error instead of hitting an ASSERT. The runtime throws it, so the existing fatal popup and fatal log record the reason. ImGui shutdown now skips backends that never started
Staging wait	Uses a generation-checked map state (a retired callback can't mark the current buffer mapped), checks for device loss inside the wait, then sleeps instead of spinning

Validation

• PR checks are green. "Recompilation test / Windows runtime (synthetic DOL)" compiles Aurora and the full runtime from scratch and links WiiCompiled.exe, so every change here builds and links on Windows.
• gx_fifo_tests built from the fork sources against Dawn headers in a local Linux harness: 358/358 pass. On openxr-work the suite was 346/347; the failure was the TEV liveness test fixed here.
• The 10 new or changed draw and GEN_MODE tests all fail when run against the unfixed command processor, so they test the fork's own merge path.
• The new WGSL helper passes naga validation, and the other changed files pass clang++ -fsyntax-only on Linux.
• Not run: a Frame (Linux/SteamOS) build and the headset. Before merging, this needs a Frame build (steam-frame-install.sh) and a race or two, checking the log for Ignoring cache entry, Unsupported blit destination format and begin_frame aborted.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Wg7mB8ogCWmp9GH19Uc82B