feat: add @emoji-mart/vue wrapper package - #1026
Open
4A2RfF5Q5x wants to merge 14 commits into
Open
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Vue passes HTML attribute names as kebab-case (e.g. `on-emoji-click`), but the Picker expects camelCase props. This adds a `normalizeAttrs` helper applied on both mount and watch so all attrs are correctly forwarded. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
@emoji-mart/vue— a thin Vue 3 wrapper for emoji-mart, mirroring the existing@emoji-mart/reactpackage in structure and API.What's included
packages/emoji-mart-vue/vue.ts—EmojiPickercomponent built with Vue 3's Composition API (defineComponent+setup). Mounts the corePickerimperatively into a<div>ref, watches reactive attrs for live updates, and callsdisconnectedCallbackon unmount to prevent listener leaks.packages/emoji-mart-vue/utils.ts—normalizeAttrshelper that converts kebab-case Vue HTML attributes (e.g.emoji-select) to camelCase props expected by the core Picker.packages/emoji-mart-vue/package.json— workspace package wired up withemoji-martas a peer dependency.packages/emoji-mart-vue/README.md— basic install + usage example.README.md— Vue usage example added alongside the existing React one.package.json—@emoji-mart/vueregistered as a Yarn workspace.Usage
Notes
picker.update(), which callscomponentWillReceivePropsinternally.categoriesandcustomprops trigger a full grid reset when changed.skinandthemeprops re-render without a grid reset.locale,set,data) are not reactive after mount — they are applied at initialization only. This is a limitation of the core Picker, not the Vue wrapper.Missive conversation: https://mail.missiveapp.com/#inbox/conversations/e35e5c44-9333-43a4-bd61-a9cd47defb14