Skip to content

Feature/frequently used remove stale data usage #1021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
patotoma wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Feature/frequently used remove stale data usage #1021

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4475db7
Frequently-used helper use fresh data instead of stale
patotoma Jan 26, 2026
236ecb7
Frequently-used fix Assignment to constant variable issue
patotoma Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 14 additions & 16 deletions packages/emoji-mart/src/helpers/frequently-used.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,34 +19,32 @@ const DEFAULTS = [
'heart',
]

let Index: any | null = null

function add(emoji: { id: string }) {
Index || (Index = Store.get('frequently') || {})
const frequently = Store.get('frequently') || {}

const emojiId = emoji.id || emoji
if (!emojiId) return

Index[emojiId] || (Index[emojiId] = 0)
Index[emojiId] += 1
frequently[emojiId] || (frequently[emojiId] = 0)
frequently[emojiId] += 1

Store.set('last', emojiId)
Store.set('frequently', Index)
Store.set('frequently', frequently)
}

function get({ maxFrequentRows, perLine }) {
if (!maxFrequentRows) return []

Index || (Index = Store.get('frequently'))
let frequently = Store.get('frequently')
let emojiIds = []

if (!Index) {
Index = {}
if (!frequently) {
frequently = {}

for (let i in DEFAULTS.slice(0, perLine)) {
const emojiId = DEFAULTS[i]

Index[emojiId] = perLine - i
frequently[emojiId] = perLine - i
emojiIds.push(emojiId)
}

Expand All @@ -56,13 +54,13 @@ function get({ maxFrequentRows, perLine }) {
const max = maxFrequentRows * perLine
const last = Store.get('last')

for (let emojiId in Index) {
for (let emojiId in frequently) {
emojiIds.push(emojiId)
}

emojiIds.sort((a, b) => {
const aScore = Index[b]
const bScore = Index[a]
const aScore = frequently[b]
const bScore = frequently[a]

if (aScore == bScore) {
return a.localeCompare(b)
Expand All @@ -77,15 +75,15 @@ function get({ maxFrequentRows, perLine }) {

for (let removedId of removedIds) {
if (removedId == last) continue
delete Index[removedId]
delete frequently[removedId]
}

if (last && emojiIds.indexOf(last) == -1) {
delete Index[emojiIds[emojiIds.length - 1]]
delete frequently[emojiIds[emojiIds.length - 1]]
emojiIds.splice(-1, 1, last)
}

Store.set('frequently', Index)
Store.set('frequently', frequently)
}

return emojiIds
Expand Down
Loading