Skip to content

Make terminal dashboard use all of the log area (not just 10 items) - #97

Open
tomballgithub wants to merge 3 commits into
misiektoja:devfrom
tomballgithub:dash_log_size
Open

Make terminal dashboard use all of the log area (not just 10 items)#97
tomballgithub wants to merge 3 commits into
misiektoja:devfrom
tomballgithub:dash_log_size

Conversation

@tomballgithub

Copy link
Copy Markdown
Collaborator

I used Claude for this. I noticed less than half of the terminal dashboard log area was being used due to hardcoding. Turns out it is not simple to query the size of that box, and so this workaround is needed. Note that Claude couldn't figure this out, and I had to search on how to find the box size from Rich (it's tricky) and gave that info to Claude.

I have noticed a similar issue in the web dashboard, it's not using all the area. I'm not tackling that.

@misiektoja

Copy link
Copy Markdown
Owner

I need to give it some more thought! The direction makes sense and I think we might have to consider a slightly different layout so the log can expand when there is room, but the main target table does not lose too much space on smaller terminals.

@tomballgithub

Copy link
Copy Markdown
Collaborator Author

That's fine. I don't really use either dashboard, but I noticed this half full log space allocated and wanted to make it usable.

@tomballgithub

Copy link
Copy Markdown
Collaborator Author

I did notice with the flagging code, that the long error message I put into the status works great everywhere except the terminal dashboard. In config mode of that dashboard, with only two accounts, that message causes the top box with the targets to roll down into the config information box. My point is that view is already tight on vertical space. User mode might be worse because the log box goes all the way to underneath the target box. Not sure how all those rich boxes get regenerated and recalculated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants