Repository navigation
linux: fall back to a free proxy port when the configured one is taken - #236
Merged
Merged
Conversation
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Linux handhelds a taken proxy port (8080 by default) made the start fail with "Port 8080 already in use - change proxy_port in config.json", which gave users no way to continue short of finding and editing the file.
proxy_portinconfig.jsonand logs a warning. If none is free, the old error is raised.Not covered: the DarkOS systemd path, which keeps its old behavior.
Tested
muOS device: stopped the service, held 8080 and 8081 with other listeners, then ran
start-proxy. The log showsPort 8080 is in use, switched proxy_port to 8082, the proxy listened on 8082, andcheevos_custom_hostwas patched to127.0.0.1:8082. The real install was restored afterwards.