Don't add Transfer-Encoding to responses that cannot have a body. - #1141
Open
mefyl wants to merge 1 commit into
Open
Don't add Transfer-Encoding to responses that cannot have a body.#1141mefyl wants to merge 1 commit into
mefyl wants to merge 1 commit into
Conversation
RFC 7230 §3.3.1 forbids Transfer-Encoding in 1xx, 204, and 304 responses. The previous cohttp 6.x change that defaulted Unknown encoding to Chunked did not account for these response types, causing e.g. WebSocket 101 Switching Protocols responses to include a spurious Transfer-Encoding: chunked header and a trailing chunked body terminator (0\r\n\r\n), breaking the WebSocket handshake for conforming clients.
Member
|
I think the tests need to be updated? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 7230 §3.3.1 forbids Transfer-Encoding in 1xx, 204, and 304 responses. The previous cohttp 6.x change that defaulted Unknown encoding to Chunked did not account for these response types, causing e.g. WebSocket 101 Switching Protocols responses to include a spurious Transfer-Encoding: chunked header and a trailing chunked body terminator (
0\r\n\r\n), breaking the WebSocket handshake for conforming clients.