Skip to content

Undo deprecation of connection value #1114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avsm merged 1 commit into from
Aug 20, 2026
Merged

Undo deprecation of connection value #1114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cohttp-eio/src/server.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ open Utils
module IO = Io.IO

type body = Body.t
type conn = IO.conn * Cohttp.Connection.t [@@warning "-3"]
type conn = IO.conn * Cohttp.Connection.t
type writer = Http.Request.t * IO.oc
type response = writer -> unit

Expand Down
2 changes: 1 addition & 1 deletion cohttp-lwt/src/server.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
open Lwt.Infix
module Header = Cohttp.Header
module Connection = Cohttp.Connection [@@warning "-3"]
module Connection = Cohttp.Connection

module Make (IO : S.IO) = struct
module IO = IO
Expand Down
2 changes: 1 addition & 1 deletion cohttp-mirage/src/static.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
*)

module Key = Mirage_kv.Key
module Connection = Cohttp.Connection [@@warning "-3"]
module Connection = Cohttp.Connection

module HTTP (FS : Mirage_kv.RO) (S : Cohttp_lwt.S.Server) = struct
open Lwt.Infix
Expand Down
2 changes: 1 addition & 1 deletion cohttp/src/cohttp.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ module Accept = Accept
module Auth = Auth
module Body = Body
module Conf = Conf
module Connection = Connection [@@deprecated "Connection.t values are useless."]
module Connection = Connection
module Code = Code
module Cookie = Cookie
module Header = Header
Expand Down
2 changes: 1 addition & 1 deletion cohttp/src/server.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ module type S = sig
module IO : S.IO

type body
type conn = IO.conn * Connection.t [@@warning "-3"]
type conn = IO.conn * Connection.t
type response

type response_action =
Expand Down