Skip to content

riskinputra firstCommit - #20

Open
riskinputra wants to merge 2 commits into
masterfrom
riskinputra
Open

riskinputra firstCommit#20
riskinputra wants to merge 2 commits into
masterfrom
riskinputra

Conversation

@riskinputra

Copy link
Copy Markdown

Untuk Roman Numeral Biasa

@Windiana

Copy link
Copy Markdown

hi risky, code km sudah bagus dan rapih.. silahkan lihat code dibawah ini, saya coba refactor berdasarkan code yang sudah km buat :

function to_roman (num) {
// your implementation code here
/*

  1. Dekalrasikan angka dengan romawinya;
  2. Pisahkan angka kedalam golongan.
  3. Dan untuk yang pola romawinya sama bisa menggunakan perulangan
    */

var angka = [1000, 900, 500, 400, 100, 90, 50, 40, 10, 9, 5, 4, 1]
var roman = ['M', 'CM', 'D', 'CD', 'C', 'XC', 'L', 'XL', 'X', 'IX', 'V', 'IV', 'I']

let hasil ='';

while(num > 0) {

for(let i=0; i<angka.length; i++) {
  if(num >= angka[i]){
    hasil += roman[i];
    num -= angka[i];
  }
}

}

return hasil;

}

// Drive code
console.log('My totally sweet testing script for new roman\n')
console.log('input | expected | actual')
console.log('——————|——————————|———————')
console.log('1 | I | ', to_roman(1))
console.log('3 | III | ', to_roman(3))
console.log('4 | IV | ', to_roman(4))
console.log('5 | V | ', to_roman(5))
console.log('8 | VIII | ', to_roman(8))
console.log('9 | IX | ', to_roman(9))
console.log('13 | XIII | ', to_roman(13))
console.log('1453 | MCDLIII | ', to_roman(1453))
console.log('1646 | MDCXLVI | ', to_roman(1646))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants