Skip to content

Add new table to mock datastore athena instance - #44919

Merged
Ben Carter (ben-cart3r) merged 1 commit into
mainfrom
add-new-table
Aug 14, 2026
Merged

Add new table to mock datastore athena instance#44919
Ben Carter (ben-cart3r) merged 1 commit into
mainfrom
add-new-table

Conversation

@ben-cart3r

Copy link
Copy Markdown
Contributor

No description provided.

@ben-cart3r
Ben Carter (ben-cart3r) requested a review from a team as a code owner August 14, 2026 14:12

@cloud-platform-actions cloud-platform-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are potential IAM Role and/or policy Changes/additions. Reviewer - If satisfied with the changes/additions - dismiss this request

@sablumiah

Copy link
Copy Markdown
Contributor

Terraform Plan Summary

Terraform Plan: 4 to be created, 0 to be destroyed, 2 to be updated, 0 to be replaced and 158 unchanged.

Resources to create:

+ aws_glue_catalog_table.orders_activations_positions
+ module.hmpps_electronic_monitoring_crime_matching_algorithm.time_rotating.weekly
+ module.hmpps_electronic_monitoring_crime_matching_api.time_rotating.weekly
+ module.hmpps_electronic_monitoring_crime_matching_ui.time_rotating.weekly

Resources to update:

! aws_iam_role_policy.mock_datastore_policy
! module.rds.aws_db_parameter_group.custom_parameters

@sablumiah

Copy link
Copy Markdown
Contributor

This PR CANNOT be auto approved and requires manual approval from the Cloud Platform team.
Reason:
🕵️‍♂️ Manual review required: OPA auto approve policy checks did not pass.

Test Passed? Reason
allowlist This PR includes changes to modules / resources which are not on the allowlist, so we can't auto approve these changes. Please request a Cloud Platform team member's review in #ask-cloud-platform
ecr Valid ECR related terraform changes
hmpps-template Valid hmpps template related terraform changes
irsa Valid irsa related terraform changes
kubernetes_secret Valid K8s secret related terraform changes
rds Valid RDS module related terraform changes
secrets_manager Valid secrets manager related terraform changes
service_pod Valid Service pod related changes
sns Valid sns related terraform changes

Please raise it in #ask-cloud-platform Slack channel.

@ben-cart3r
Ben Carter (ben-cart3r) enabled auto-merge (squash) August 14, 2026 14:16
@ben-cart3r
Ben Carter (ben-cart3r) merged commit eafb3df into main Aug 14, 2026
12 checks passed
@ben-cart3r
Ben Carter (ben-cart3r) deleted the add-new-table branch August 14, 2026 14:19
@sablumiah

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants