Skip to content

Pi 3930 sentence plan and delius queue dev - #44918

Merged
hazzaz-justice merged 3 commits into
mainfrom
PI-3930-sentence-plan-and-delius-queue-dev
Aug 14, 2026
Merged

Pi 3930 sentence plan and delius queue dev#44918
hazzaz-justice merged 3 commits into
mainfrom
PI-3930-sentence-plan-and-delius-queue-dev

Conversation

@hazzaz-justice

Copy link
Copy Markdown
Contributor

No description provided.

@hazzaz-justice
hazzaz-justice requested a review from a team as a code owner August 14, 2026 13:07

@cloud-platform-actions cloud-platform-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are potential IAM Role and/or policy Changes/additions. Reviewer - If satisfied with the changes/additions - dismiss this request

@cloud-platform-actions cloud-platform-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are potential IAM Role and/or policy Changes/additions. Reviewer - If satisfied with the changes/additions - dismiss this request

@sablumiah

Copy link
Copy Markdown
Contributor

Terraform Plan Summary

Terraform Plan: 14 to be created, 0 to be destroyed, 2 to be updated, 0 to be replaced and 515 unchanged.

Resources to create:

+ aws_sns_topic_subscription.sentence-plan-and-delius-queue-subscription
+ aws_sqs_queue_policy.sentence-plan-and-delius-dlq-policy
+ aws_sqs_queue_policy.sentence-plan-and-delius-queue-policy
+ kubernetes_secret.sentence-plan-and-delius-queue-secret
+ module.sentence-plan-and-delius-dlq.aws_iam_policy.irsa
+ module.sentence-plan-and-delius-dlq.aws_sqs_queue.terraform_queue
+ module.sentence-plan-and-delius-dlq.random_id.id
+ module.sentence-plan-and-delius-queue.aws_iam_policy.irsa
+ module.sentence-plan-and-delius-queue.aws_sqs_queue.terraform_queue
+ module.sentence-plan-and-delius-queue.random_id.id
+ module.sentence-plan-and-delius-service-account.kubernetes_service_account.generated_sa
+ module.sentence-plan-and-delius-service-account.module.iam_assumable_role.aws_iam_role.this[0]
+ module.sentence-plan-and-delius-service-account.module.iam_assumable_role.aws_iam_role_policy_attachment.this["sqs"]
+ module.sentence-plan-and-delius-service-account.random_id.id

Resources to update:

! aws_iam_policy.sqs_management_policy["dlq"]
! aws_iam_policy.sqs_management_policy["queue"]

@sablumiah

Copy link
Copy Markdown
Contributor

This PR CANNOT be auto approved and requires manual approval from the Cloud Platform team.
Reason:
🕵️‍♂️ Manual review required: OPA auto approve policy checks did not pass.

Test Passed? Reason
allowlist This PR includes changes to modules / resources which are not on the allowlist, so we can't auto approve these changes. Please request a Cloud Platform team member's review in #ask-cloud-platform
ecr Valid ECR related terraform changes
hmpps-template Valid hmpps template related terraform changes
irsa Valid irsa related terraform changes
kubernetes_secret Valid K8s secret related terraform changes
rds Valid RDS module related terraform changes
secrets_manager Valid secrets manager related terraform changes
service_pod Valid Service pod related changes
sns Valid sns related terraform changes

Please raise it in #ask-cloud-platform Slack channel.

@hazzaz-justice
hazzaz-justice merged commit b46e0ae into main Aug 14, 2026
12 checks passed
@hazzaz-justice
hazzaz-justice deleted the PI-3930-sentence-plan-and-delius-queue-dev branch August 14, 2026 14:58
@sablumiah

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants