Add bounded multipart upload parallelism#228
Open
jiuker wants to merge 2 commits into
Open
Conversation
Add bounded multipart upload parallelism
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #216
Add bounded multipart upload parallelism
PutObjectnow supports concurrentUploadPartcalls via the newPutObjectArgs::max_inflight_partsfield (default1= sequential behavior preserved).Changes
include/miniocpp/args.hunsigned int max_inflight_parts = 1toPutObjectArgssrc/args.ccmax_inflight_parts > 0src/client.ccPutObjectinto sequential + parallel branchestests/tests.ccPutObjectWithInflight()— MD5 integrity testsrc/client.cchighlightsmax_inflight_parts <= 1): Original single-buffer loop, unchanged.max_inflight_parts > 1):AlignedBufferpool.std::asyncdispatchesUploadPart.std::deque+drain_onelambda.CompleteMultipartUploaddoesn't care about completion order.one_byteread-ahead indexing in the unknown-size path (buf[part_size]instead ofbuf[part_size + 1]).Testing
PutObjectWithInflight()generates 10MB of random data, computes the original MD5, uploads withmax_inflight_parts = 1, 2, 4, downloads each object, and verifies MD5 matches the original.