Fix cascade comments that overstate the unlayered-CSS guarantee - #30
Merged
Conversation
Two comments claimed unlayered site CSS beats every framework layer. That is only true for normal declarations: every helper declaration is !important, and important layered declarations beat unlayered CSS, so helpers win over site and consumer CSS by design (the prose in docs/start and agents/css.md already says so). - docs/start code block: qualify the claim and state the helpers exception - _global.css: same fix, and correct the @layer pages rationale (it claimed pages exists so helpers can override those rules, but helpers override unlayered rules too; pages is for site rules that should stay below unlayered CSS while still beating the framework's components) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
✅ Deploy Preview for mcssdev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two comments claimed unlayered site CSS "wins over every mCSS layer". That is only true for normal declarations: every helper declaration is
!important, and important layered declarations beat unlayered CSS, so helpers win over site and consumer CSS by design. The prose indocs/start("Your CSS (unlayered)" section) andagents/css.mdalready state the exception correctly; these two comments contradicted them.docs/startcode block: now says normal declarations win over every layer, with the helpers exception spelled out._global.css: same fix, plus a corrected rationale for@layer pages. The old comment said pages exists so "helpers can still override" those rules, but helpers override unlayered rules too, so that reasoning was based on the same false premise. Pages is for site rules that should stay below your unlayered CSS while still beating the framework's components.Comment-only change: no rendered CSS or dist output is affected.
Verification
npm run buildpasses; the rebuilt/docs/startshows the corrected code block and the old claim is gone.grep -rn "wins over every"no longer matches anywhere in src.🤖 Generated with Claude Code