move() actual coordinates is wrong - #11
Open
drzraf wants to merge 2 commits into
Open
Conversation
- By doing relative move() step after step, trigonometric computation would accumulate floating-point inaccuracies along the loop - x/centerx were conflated leading to move() being rect.width/2 inferior to the expectation (same for y/centery) - This was encounterd (and can be reproduced) using: ``` robot.penDown() robot.rotate(45) robot.move(DISTANCE) robot.rotate(-90) robot.move(DISTANCE) robot.rotate(-135) robot.move(DISTANCE * math.sqrt(2)) ``` Expected: The robot is back exactly its starting point. Actual: It's not because both move(DISTANCE) were actually less than DISTANCE.
drzraf
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a small fix for Python3 / latest pygame version which require an integer to be passed to
move()but more importantly, fixes a (dx/dy) computation error inmove()Example:
Green points added for convenience to show the true place the robot should have moved to (based on correct
math.cos(math.radians(self.heading)) * distancecalculation between start and end points) [omit the left-most green point]Actual:
As you can see,
move()is shorter than what it should be due to a confusion between rect's(x, y)and(centerx, centery). The fact thatmove()does trigonometric computation in a loop adds up inaccuracy to the error.Expected (and using present PR):
