MOBILE-284: support shouldIncludeVersionCode parameter for init#213
Open
sergeysozinov wants to merge 1 commit into
Open
MOBILE-284: support shouldIncludeVersionCode parameter for init#213sergeysozinov wants to merge 1 commit into
sergeysozinov wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an optional shouldIncludeVersionCode flag to the React Native SDK initialization flow so it can be forwarded through the JS bridge and applied in the Android native configuration.
Changes:
- Extended
InitializationDatawithshouldIncludeVersionCode?: boolean. - Updated JS
initialize()to conditionally includeshouldIncludeVersionCodein the init payload. - Updated Android native module to read
shouldIncludeVersionCodefrom the payload and apply it toMindboxConfiguration.Builder. - Added unit tests verifying the JS payload includes/omits the flag appropriately.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/types/InitializationData.ts |
Adds the new optional initialization field to the public type. |
src/index.tsx |
Passes shouldIncludeVersionCode through to the native initialize payload and documents it in the example. |
src/__tests__/index.test.ts |
Adds tests to ensure the init payload includes/omits the new field correctly. |
android/src/main/java/com/mindboxsdk/MindboxSdkModule.kt |
Applies shouldIncludeVersionCode to the Android configuration builder when present in the payload. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| * previousInstallId: '', | ||
| * previousUuid: '', | ||
| * operationsDomain: 'anonymizer.example.com', | ||
| * shouldIncludeVersionCode: false, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://tracker.yandex.ru/MOBILE-284