MOBILE-283: remove default domain#210
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Removes the implicit Android default API domain from the React Native Mindbox SDK initialization path, making the domain explicitly required to align with the public JS types and initialization contract.
Changes:
- Updated Android native initialization to require
domainandendpointIdfrom the initialization payload (no fallback defaults). - Updated the JS documentation example to use a placeholder domain rather than
api.mindbox.ru.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/index.tsx | Updates the initialization JSDoc example domain to a non-default placeholder. |
| android/src/main/java/com/mindboxsdk/MindboxSdkModule.kt | Removes the default domain/endpointId values, requiring both keys in the payload. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
justSmK
approved these changes
Jul 16, 2026
justSmK
left a comment
justSmK
left a comment
Collaborator
There was a problem hiding this comment.
Не забудь пожалуйста про ветку new-arch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://tracker.yandex.ru/MOBILE-283