Repository navigation
fix(contract): avoid partial index repair when a later resource fails validation - #1153
Closed
jeffrey-graham wants to merge 1 commit into
Closed
jeffrey-graham wants to merge 1 commit into
jeffrey-graham wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validates all entries in
repair_indexandrepair_tag_index(bounds check,validate_resource_id, resource existence and supported schema version viaload, and duplicate detection) before performing any storage mutations or index cleanup.idsfails validation (InvalidResourceId,NotFound,UnsupportedResourceSchema, orDuplicateInRepair).contract/contracts/vault-registry/src/test.rsandcontract/contracts/vault-registry/src/test/lifecycle_roles.rsverifying thatResourceCount,IndexKey,TagCount,TagEntry, andNextTagSeqremain completely unchanged when any later item fails.contract/README.md,docs/index-repair.md, anddocs/tag-index-repair-design.md.Verification
cargo test repair_ && cargo test readme_ && cargo test event_schema_ && cargo test storage_key_(28/28 passed)Closes #1070