Adds mod for Arcify - #6
Open
dansimco wants to merge 2 commits into
Open
Conversation
Owner
|
This looks great - love the way the mod just sits on top of the existing library API. I’ll wait to see how the discussion and testing on the lines thread shakes out before we merge to master. |
Author
|
I'm making some changes today, which should better use the arcify style delta scaling. I didn't notice the min/max interpolation stuff before. |
|
I'm so glad I looked - I was just making this same change! Such an amazing script, Arc really enhances it!!! |
Author
|
There may be a need/opportunity to refactor this given the new LFO API in the latest norns. update. I'm away from norns/home/country at the moment so I'm not totally sure but I can take a look in a couple of weeks when I'm back. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr adds mod capability for arcify
In order to make it user mappable, the mod scans for all available parameters and excludes some system params that are undesirable for mapping, the list is at the top of the file if you want to enable any of them.
Because I couldn't inspect a min and max value for arbitrary parameters, I added a "sensitivity" control. This is configured by
sens_maxin the mod file. The higher the number, the smaller the delta value will be, so increasing the maximum will also decrease the delta applied when sensitivity = 1. With some tweaking of sensitivity when mapping a param to an arc you can get pretty close to an even feel across params which scale from -1 to +1 alongside numbers in the thousands.There could well be a much more elegant way to do this :) .
Mappings save with psets, and should load fine on script load. Had to re-init the default params on load to be able to the default arcify values applied on first load.