fix: return False for non-sized binary vector values - #3777
Open
krudo-taco wants to merge 1 commit into
Open
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: krudo-taco The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @krudo-taco! It looks like this is your first PR to milvus-io/pymilvus 🎉 |
check_invalid_binary_vector called len() before isinstance(..., bytes), so None or int rows raised TypeError instead of a ParamError. Check the type first, including the first row used for the dimension. Fixes milvus-io#3768 Signed-off-by: zhihaovme50 <wanzft1@gmail.com>
krudo-taco
force-pushed
the
fix/binary-vector-nonsized-values
branch
from
August 26, 2026 22:26
1a5f5d0 to
d3b253b
Compare
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check_invalid_binary_vectorcalledlen()beforeisinstance(..., bytes),so rows like
NoneorintraisedTypeErrorinstead of letting the callerraise
ParamError.Check the type first, including the first row used for the dimension.
Fixes #3768