fix: report partition_names in validation errors instead of the internal key - #3763
Open
sainikhiljuluri wants to merge 1 commit into
Open
Conversation
…nal key
check_pass_param was called with the internal key partition_name_array, and
_raise_param_error formats the registry key straight into the message, so an
invalid value reported a parameter name that appears nowhere in the public API:
`partition_name_array` value 1 is illegal
Register the validator under partition_names and pass that name from the call
sites. The old key stays registered so anything still passing it keeps being
validated.
Fixes milvus-io#2589
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Signed-off-by: Sainikhil Juluri <sainikhiljuluri19008@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sainikhiljuluri The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @sainikhiljuluri! It looks like this is your first PR to milvus-io/pymilvus 🎉 |
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
check_pass_paramwas called with the internal keypartition_name_array, and_raise_param_error(check.py:261) formats the registry key straight into the message. So an invalid value reported a parameter name that appears nowhere in the public API:There is no
partition_name_arrayargument to look up.Fix
Register the validator under
partition_namesand pass that name from the 10 internal call sites.partition_name_arraystays registered, so anything still passing it keeps being validated rather than tripping theunknown parambranch.Production change is a pure rename plus one registry line — no validation behaviour changes.
Tests
make unittest→ 4541 passed, 3 skipped (baseline 4536; +5 new).make lintclean.TestLoadPartitionsRequestintests/unit/prepare/test_collection.pygoes through the real path (Prepare.load_partitions) and asserts the message namespartition_names. Reverting the call site makes it fail with`partition_name_array` value ['p1', 1] is illegal— the bug itself, not a setup error.TestPartitionNamesErrorMessageintests/unit/test_client_validators.pycovers the registry directly, including that the old key still validates.Fixes #2589