fix(LoopBase): handle stop=0 in __getitem__ slice - #3762
Open
astitvabajpai wants to merge 1 commit into
Open
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: astitvabajpai The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @astitvabajpai! It looks like this is your first PR to milvus-io/pymilvus 🎉 |
if item.stop treated stop=0 as falsy, causing page[0:0] to return all elements instead of an empty list. Change the guard to if item.stop is not None so a legitimate stop value of 0 is respected while a missing stop (None) still falls back to the full length. Adds regression test test_loop_base_getitem_slice_stop_zero covering the reported edge cases. Fixes milvus-io#3543 Signed-off-by: astitvabajpai <astitvabajpai22@gmail.com>
astitvabajpai
force-pushed
the
fix/3543-loopbase-getitem-stop-zero
branch
from
August 16, 2026 11:07
de5771e to
da46493
Compare
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3543
LoopBase.__getitem__usedif item.stopto decide the slice end, but0is falsy in Python. This causedpage[0:0]to silently return all elements instead of an empty list, breaking pagination edge cases inSearchPageand the search iterator.Root Cause
In
pymilvus/client/abstract.py, theLoopBase.__getitem__method had: