Skip to content

enhance: resolve global cluster topology via DNS SRV records #3753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huanghaoyuanhhy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

enhance: resolve global cluster topology via DNS SRV records #3753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions pymilvus/client/connection_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,9 @@ def _fetch_and_start_refresher(self, config: ConnectionConfig) -> GlobalTopology
Returns:
The fetched GlobalTopology (caller uses it to connect to primary).
"""
topology = fetch_topology(config.uri, config.token)
topology = fetch_topology(
config.uri, config.token, on_topology_change=self._on_topology_change
)

with self._lock:
self._topology = topology
Expand All @@ -338,6 +340,7 @@ def _fetch_and_start_refresher(self, config: ConnectionConfig) -> GlobalTopology
token=config.token,
topology=topology,
on_topology_change=self._on_topology_change,
get_current=self.get_topology,
)
self._refresher.start()
return topology
Expand All @@ -353,11 +356,16 @@ def on_unavailable(self, managed: ManagedConnection) -> bool:
return True # No config, trigger recovery

with self._lock:
old_primary = self._topology.primary.endpoint if self._topology else None
old_topology = self._topology
old_primary = old_topology.primary.endpoint if old_topology else None

# Fetch fresh topology
try:
new_topology = fetch_topology(self._config.uri, self._config.token)
new_topology = fetch_topology(
self._config.uri,
self._config.token,
cached_version=old_topology.version if old_topology else None,
)
except Exception:
logger.warning("Failed to refresh topology on UNAVAILABLE", exc_info=True)
return True # Error fetching, trigger recovery anyway
Expand Down
Loading
Loading